Skip to content

Fixed github link metadata #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
himorin wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixed github link metadata #631

himorin wants to merge 3 commits into from
+2 −13

Conversation

@himorin
Copy link
Contributor

@himorin himorin commented Dec 21, 2025

as title.

Also,,, how about:

  1. on previousMaturity and PreviousPublishDate

it seems:

  • Previous Versions in document details header has been made optional
  • we don't include previousPublishDate metadata but just have previousMaturity
  • respec documentation on previousMaturity routine does not check generated link is correct (by means, pair of maturity and published date)
  • published spec will have history link in its document details header

how about to remove both previousMaturity (line 18) and previousPublishDate (line 25)? (which also may cause our mistake!)

  1. use // instead of /* */ for comment

block type commented out is confusing and we may edit line by line, as well as switch enable/disable line by line, in metadata lines, how about not to use /* */?

@himorin
Copy link
Contributor Author

himorin commented Dec 21, 2025

ah, also how about to remove imsc1/spec/manifest.txt file which is no longer used?

if all three are fine for both @nigelmegitt and @palemieux , I would update this PR.

nigelmegitt
nigelmegitt reviewed Jan 7, 2026
View reviewed changes
imsc1/spec/ttml-ww-profiles.html
Comment on lines 4113 to +4115



Copy link
Contributor

@nigelmegitt nigelmegitt Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange white space appended to end of file.

@nigelmegitt
Copy link
Contributor

nigelmegitt commented Jan 7, 2026

ah, also how about to remove imsc1/spec/manifest.txt file which is no longer used?

if all three are fine for both @nigelmegitt and @palemieux , I would update this PR.

Happy to remove unused files. Does this have any interaction with PR Preview not working? Or was it only used for echidna auto-publication?

@himorin
Copy link
Contributor Author

himorin commented Jan 8, 2026

ah, also how about to remove imsc1/spec/manifest.txt file which is no longer used?
if all three are fine for both @nigelmegitt and @palemieux , I would update this PR.

Happy to remove unused files. Does this have any interaction with PR Preview not working? Or was it only used for echidna auto-publication?

this was used for locally executed automation tool (not sure it was echidna or not, but some command line tool without integration with spec building tool like bikeshed or respec), and not used for spec-prod GH workflow.
I have no idea with pr-preview, but I saw some repository had issue that pr-preview does not update issue description with built one in Dec last year, without any idea whether these are related or not.

@nigelmegitt nigelmegitt mentioned this pull request Jan 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nigelmegitt nigelmegitt nigelmegitt left review comments

@palemieux palemieux palemieux approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@himorin @nigelmegitt @palemieux